Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend pipeline for newer versions php #744

Closed
wants to merge 19 commits into from

Conversation

DannyvdSluijs
Copy link
Collaborator

This PR updates the pipeline to include PHP >= 8.0 and no longer include PHP <= 7.1. In addition the PR contains the following changes to have green results.

  • Update to PHPUnit 8.5 to resolve invocations of deprecated/removed method each(), see https://www.php.net/manual/en/function.each.php. Which resulted in:
    • Add void return types to ::setup() methods
    • Explicitly include phpspec/prophecy
    • Replace ::setExpectedException() and @ExpectedException for ::expectException
    • Replace ::assertInternalType() with assertIs*() methods
    • Replace ::getMock() with ::createMock()
  • Improve test assertions in case of warning or error during test run.
  • Port Fix ObjectIterator for PHP8 #682 to fix deprecations from ObjectIterator
  • Update icecave/parity to ^3,0 to resolve invocations of deprecated/removed method each()
  • Correct styles reported by GHA workflow

@DannyvdSluijs DannyvdSluijs deleted the Extend-pipeline-for-newer-versions-php branch August 5, 2024 07:25
@DannyvdSluijs
Copy link
Collaborator Author

Has been replaced with #746

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant